Review Request 109829: Why do we need restoreState?

[Alexander Dymo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109829/#review30431
-----------------------------------------------------------


Maybe we save/restore toolbars?

- Alexander Dymo


On April 4, 2013, 11:41 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109829/
> -----------------------------------------------------------
> 
> (Updated April 4, 2013, 11:41 p.m.)
> 
> 
> Review request for KDevelop and Alexander Dymo.
> 
> 
> Description
> -------
> 
> I had been hitting some ugly bug recently, where KDevelop would initialize in a weird state where one of the docks was shown but the button wasn't checked, so I had to press the button to hide it (hotkeys didn't work).
> 
> I decided to investigate when were the hidden toolviews shown. gdb soon suggested it was in restoreState(). I started to fiddle with the code to see what could be wrong, but I couldn't manage to find out, so I tried to disable it. It worked (surprisingly good I must add, most of the glitches I had when changing areas are gone with this change).
> 
> This is not a proper review request, but I was wondering what are we trying to restore there. Toolviews and menues are managed elsewhere, so are the document views. The size isn't being restored there either (load/saveGeometry).
> 
> 
> This addresses bug 295536.
>     http://bugs.kde.org/show_bug.cgi?id=295536
> 
> 
> Diffs
> -----
> 
>   sublime/mainwindow.cpp 9d55ca6 
> 
> Diff: http://git.reviewboard.kde.org/r/109829/diff/
> 
> 
> Testing
> -------
> 
> All tests pass (but testgenerationtest), didn't add any other test.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130405/3486b798/attachment-0001.html>