Review Request: Fix stale suffix text removal in (and refactor) SIGNAL()/SLOT() completion.

Ivan Shapovalov intelfx100 at
Tue Sep 25 09:31:00 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 25, 2012, 9:31 a.m.)

Review request for KDevelop and Olivier Jean de Gaalon.


- Added unit-tests
- Separated new code into a function, which is now used also from the implementation helper item
- Adopted fixes from comments


Most notably, I stopped using a complicated regex for detecting
pieces of stale SIGNAL()/SLOT() macros like in
"SIGNAL( <cursor here> someOldStuff(withArguments) )".
Instead, just delete everything from cursor to next
statement delimiter or EOL or unrelated closing bracket.

Also, added extensive comments on what's being done
as the code was pretty unclear.

This addresses bugs 202135 and 224996.

Diffs (updated)

  languages/cpp/codecompletion/implementationhelperitem.cpp 5b832b1 
  languages/cpp/codecompletion/item.h fa449ca 
  languages/cpp/codecompletion/item.cpp d52c832 
  languages/cpp/tests/test_cppcodecompletion.h 24b9a19 
  languages/cpp/tests/test_cppcodecompletion.cpp 4eccce2 


Testing (updated)

Added unit-tests using examples provided in the bug-reports; existing unit-tests pass.


Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list