Review Request: Use D-Bus to lock sessions and move "session locked" dialog (from KDevelop's main()) to kdevplatform
Ivan Shapovalov
intelfx100 at gmail.com
Sat Sep 22 23:11:54 UTC 2012
> On Sept. 22, 2012, 2:30 p.m., Milian Wolff wrote:
> > When DBUS locking succeeds, I won't see a dialog when there is stale lock file - or will I? As you say in the comment, the DBUS lock should take precedence.
> >
Yes, D-Bus lock takes precedence and it means that if a D-Bus can be locked and lockfile can't, the latter is removed and re-taken. In case if it fails somewhy, or a D-Bus lock is already taken, the dialog is shown.
- Ivan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105917/#review19300
-----------------------------------------------------------
On Sept. 22, 2012, 11:10 p.m., Ivan Shapovalov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105917/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2012, 11:10 p.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> 1: Use D-Bus instead of lock-files to lock kdevplatform sessions.
>
> 2: Moved the lockfile remove dialog which currently resides in KDevelop's main() - and which is usable only when the session name is explicitly given to the application - to kdevplatform's SessionController, adjusting the dialog for "lockfile -> dbus" changes.
>
> This allows to get rid of nasty non-informative error messages about a session being already used and replace them with code that does the following things:
> 1) Attempts a DBus call to make a running instance visible;
> 2) If it didn't succeed, shows a dialog window asking permission to retry, show session chooser dialog or quit;
> 3) Repeats the entire procedure if a newly-picked session is locked too.
>
> This code is also used when one picks a session from "Sessions" menu, so a nasty error message has also been removed also from there.
>
> Related change to KDevelop is here: https://git.reviewboard.kde.org/r/105918/ .
>
>
> Diffs
> -----
>
> shell/core.cpp 206d48d
> shell/sessioncontroller.h 551894d
> shell/sessioncontroller.cpp c9fac67
>
> Diff: http://git.reviewboard.kde.org/r/105917/diff/
>
>
> Testing
> -------
>
> Existing unit-tests + manual UI testing.
>
>
> Thanks,
>
> Ivan Shapovalov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120922/9766a5ad/attachment.html>
More information about the KDevelop-devel
mailing list