Review Request: BuilderJob: (follow-up) use BuilderJob instead of SequentiallyRunJobs in CMake/make builders

Commit Hook null at kde.org
Sat Sep 22 21:53:18 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106462/#review19337
-----------------------------------------------------------


This review has been submitted with commit 19f707c49af94ee558ae3b92cce3f430a1724f78 by Ivan Shapovalov to branch master.

- Commit Hook


On Sept. 17, 2012, 7:56 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106462/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2012, 7:56 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> (Related to https://git.reviewboard.kde.org/r/106461/.)
> 
> Use BuilderJob in builders to generate composite configure+build/build+install jobs.
> This allows to avoid having nested composite jobs and generate uniform user-readable names of the composite jobs.
> 
> 
> Diffs
> -----
> 
>   projectbuilders/cmakebuilder/cmakebuilder.cpp 2ad9d74 
>   projectbuilders/makebuilder/makebuilder.cpp e0cdd02 
> 
> Diff: http://git.reviewboard.kde.org/r/106462/diff/
> 
> 
> Testing
> -------
> 
> Manual testing, existing unit-tests. Works as expected.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120922/b99ac433/attachment.html>


More information about the KDevelop-devel mailing list