Review Request: Project Manager View: get rid of BuildItemBuilderJob

Ivan Shapovalov intelfx100 at
Sat Sep 22 16:20:46 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 22, 2012, 4:20 p.m.)

Review request for KDevelop.


Fixed a style issue pointed out by Milian.


The whole and only purpose of that class is to convert KDevelop::BuildItem to KDevelop::ProjectBaseItem*.

Thus, refactor ProjectManagerViewPlugin slightly in order to separate target collection and job creation into different functions, and incorporate the aforementioned conversion into the newly-created functions. It allows to get rid of BuildItemBuilderJob completely.

Diffs (updated)

  plugins/projectmanagerview/CMakeLists.txt 3719dc7 
  plugins/projectmanagerview/builditembuilderjob.h 20ea87d 
  plugins/projectmanagerview/builditembuilderjob.cpp d5e75d0 
  plugins/projectmanagerview/projectmanagerviewplugin.h 6b15844 
  plugins/projectmanagerview/projectmanagerviewplugin.cpp 968376d 



Manual testing (building projects/targets), existing unit-tests.


Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list