Review Request: Project Manager View: get rid of BuildItemBuilderJob

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106459/#review19306
-----------------------------------------------------------

Ship it!


two small issues, otherwise is looking good.


plugins/projectmanagerview/projectmanagerviewplugin.cpp
<http://git.reviewboard.kde.org/r/106459/#comment15282>

    please wrap body in {}



plugins/projectmanagerview/projectmanagerviewplugin.cpp
<http://git.reviewboard.kde.org/r/106459/#comment15283>

    with your other review request, that is missing a "updateName" call, or?


- Milian Wolff


On Sept. 17, 2012, 7:44 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106459/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2012, 7:44 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> The whole and only purpose of that class is to convert KDevelop::BuildItem to KDevelop::ProjectBaseItem*.
> 
> Thus, refactor ProjectManagerViewPlugin slightly in order to separate target collection and job creation into different functions, and incorporate the aforementioned conversion into the newly-created functions. It allows to get rid of BuildItemBuilderJob completely.
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/CMakeLists.txt 3719dc7 
>   plugins/projectmanagerview/builditembuilderjob.h 20ea87d 
>   plugins/projectmanagerview/builditembuilderjob.cpp d5e75d0 
>   plugins/projectmanagerview/projectmanagerviewplugin.h 6b15844 
>   plugins/projectmanagerview/projectmanagerviewplugin.cpp 968376d 
> 
> Diff: http://git.reviewboard.kde.org/r/106459/diff/
> 
> 
> Testing
> -------
> 
> Manual testing (building projects/targets), existing unit-tests.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120922/fcb278a3/attachment.html>