Review Request: Adding Shortcut F2 and Delete also F5 on Project Manager View

Olivier Jean de Gaalon olivier.jg at gmail.com
Fri Sep 21 07:07:31 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106374/#review19254
-----------------------------------------------------------


Simple, and a good change. I only hesitate to green light it because it's adding a shortcut that won't work.
Could you look into what's grabbing the F5?
Or if not just remove it and add a //FIXME: instead?

- Olivier Jean de Gaalon


On Sept. 7, 2012, 7:35 p.m., Przemek Czekaj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106374/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2012, 7:35 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> It's a feature request to add to kdevelop, pressing F2 in the Project Tree Widget on the folder or file, will trigger the rename window, pressing Delete will trigger remove dialog, pressing F5 should trigger reload but doesn't get the focus on the widget :(
> 
> I do it, becasue a lot of editors have this shortcuts by default on the project tree view fe: eclipse, netbeans, jetbrains editors etc...
> 
> Regards.
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/projectmanagerviewplugin.cpp 968376d 
> 
> Diff: http://git.reviewboard.kde.org/r/106374/diff/
> 
> 
> Testing
> -------
> 
> compiled and tested, but the problem is with F5 on the Project Tree, it doesn't get the focus on this widget, just refresh the file view widget (have no idea how should it be writed... so Im very sorry)
> 
> 
> Screenshots
> -----------
> 
> Context menu, show what patch add
>   http://git.reviewboard.kde.org/r/106374/s/720/
> 
> 
> Thanks,
> 
> Przemek Czekaj
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120921/f3d6ec82/attachment.html>


More information about the KDevelop-devel mailing list