Review Request: kdevelop: Adjust CMake for project KCM selection semantic change.

Ivan Shapovalov intelfx100 at gmail.com
Thu Sep 20 15:54:07 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106513/
-----------------------------------------------------------

Review request for KDevelop and Aleix Pol Gonzalez.


Description
-------

Adjust CMake project manager/builder for this review: https://git.reviewboard.kde.org/r/106512/.
This gets rid of an unused interface requirement IMakeBuilder and implements the IBuildSystemManager::additionalBuilderPlugins() method returning either Make or Ninja builder, whatever is appropriate for the given project.


Diffs
-----

  projectbuilders/cmakebuilder/cmakebuilder.h 1f67e6a 
  projectbuilders/cmakebuilder/kdevcmakebuilder.desktop 819bca0 
  projectmanagers/cmake/cmakemanager.h 65520bf 
  projectmanagers/cmake/cmakemanager.cpp fa05061 

Diff: http://git.reviewboard.kde.org/r/106513/diff/


Testing
-------

Existing unit-tests and manual testing on both cmake+ninja and cmake+make projects (as well as on non-cmake ones).


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120920/64990977/attachment.html>


More information about the KDevelop-devel mailing list