Review Request: (code deduplication) Use OutputExecuteJob in CMakeJob

Ivan Shapovalov intelfx100 at
Wed Sep 19 16:39:04 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 19, 2012, 4:39 p.m.)

Review request for KDevelop.


Updated patch from comments and to reflect the new base class patch.

- Use IsBuilderHint property
- Pass flags to setProperties() using OR
- Do not attempt to create a working directory in ::workingDirectory()


This is related to
So, CMakeJob is ported to use the class from given review.

Diffs (updated)

  projectbuilders/cmakebuilder/cmakejob.h 6dd0a1a 
  projectbuilders/cmakebuilder/cmakejob.cpp 5e4f159 



Manual testing + existing unit-tests.


Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list