Review Request: (code deduplication) Use OutputExecuteJob in CMakeJob

[Ivan Shapovalov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106465/
-----------------------------------------------------------

(Updated Sept. 19, 2012, 4:39 p.m.)


Review request for KDevelop.


Changes
-------

Updated patch from comments and to reflect the new base class patch.

- Use IsBuilderHint property
- Pass flags to setProperties() using OR
- Do not attempt to create a working directory in ::workingDirectory()


Description
-------

This is related to https://git.reviewboard.kde.org/r/106463/.
So, CMakeJob is ported to use the class from given review.


Diffs (updated)
-----

  projectbuilders/cmakebuilder/cmakejob.h 6dd0a1a 
  projectbuilders/cmakebuilder/cmakejob.cpp 5e4f159 

Diff: http://git.reviewboard.kde.org/r/106465/diff/


Testing
-------

Manual testing + existing unit-tests.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120919/b3682485/attachment.html>