Review Request: (code deduplication) Use OutputExecuteJob in CMakeJob

[Aleix Pol Gonzalez]

> On Sept. 17, 2012, 11:46 a.m., Aleix Pol Gonzalez wrote:
> > projectbuilders/cmakebuilder/cmakejob.cpp, line 147
> > <http://git.reviewboard.kde.org/r/106465/diff/2/?file=85745#file85745line147>
> >
> >     I'm unsure this should happen here...
> 
> Ivan Shapovalov wrote:
>     Where else?
>     It has been moved from CMakeJob::start() (where it happened right after retrieving the build directory from CMake parameters) to CMakeJob::workingDirectory() (where it happens after the analogous operation).

In start maybe?

To me, calling ::workingDirectory() shouldn't change the status of the system... it's when ::start() is called that we actually commit to the action.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106465/#review19059
-----------------------------------------------------------


On Sept. 17, 2012, 11:35 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106465/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2012, 11:35 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This is related to https://git.reviewboard.kde.org/r/106463/.
> So, CMakeJob is ported to use the class from given review.
> 
> 
> Diffs
> -----
> 
>   projectbuilders/cmakebuilder/cmakejob.h 6dd0a1a 
>   projectbuilders/cmakebuilder/cmakejob.cpp 5e4f159 
> 
> Diff: http://git.reviewboard.kde.org/r/106465/diff/
> 
> 
> Testing
> -------
> 
> Manual testing + existing unit-tests.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120919/491f102b/attachment.html>