Review Request: Fix stale suffix text removal in (and refactor) SIGNAL()/SLOT() completion.

[Ivan Shapovalov]

> On Sept. 18, 2012, 6:09 a.m., Olivier Jean de Gaalon wrote:
> > I can't test it at the moment, but with a lookthrough it seems good to me.
> > Am I right to assume this can't be added to the test suites?
> > 
> >

There exists a possibility to test it, but something does not work there - a "normal" call to a signal/slot is inserted...


> On Sept. 18, 2012, 6:09 a.m., Olivier Jean de Gaalon wrote:
> > languages/cpp/codecompletion/item.cpp, line 81
> > <http://git.reviewboard.kde.org/r/106451/diff/2/?file=85660#file85660line81>
> >
> >     Ideally at least your copy could be renamed to something more accurate than "word"

This is existing code; I agree that it's a bit vague, but a fix (replace-all) is ortogonal to this patch/review...


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106451/#review19092
-----------------------------------------------------------


On Sept. 17, 2012, 4:17 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106451/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2012, 4:17 a.m.)
> 
> 
> Review request for KDevelop and Olivier Jean de Gaalon.
> 
> 
> Description
> -------
> 
> Most notably, I stopped using a complicated regex for detecting
> pieces of stale SIGNAL()/SLOT() macros like in
> "SIGNAL( <cursor here> someOldStuff(withArguments) )".
> Instead, just delete everything from cursor to next
> statement delimiter or EOL or unrelated closing bracket.
> 
> Also, added extensive comments on what's being done
> as the code was pretty unclear.
> 
> 
> This addresses bugs 202135 and 224996.
>     http://bugs.kde.org/show_bug.cgi?id=202135
>     http://bugs.kde.org/show_bug.cgi?id=224996
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codecompletion/item.cpp d52c832 
> 
> Diff: http://git.reviewboard.kde.org/r/106451/diff/
> 
> 
> Testing
> -------
> 
> Manual testing using examples provided in the bug-reports; existing unit-tests pass.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120918/b68b64b2/attachment.html>