Review Request: (code deduplication) Use OutputExecuteJob in CMakeJob

Ivan Shapovalov intelfx100 at gmail.com
Mon Sep 17 11:35:57 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106465/
-----------------------------------------------------------

(Updated Sept. 17, 2012, 11:35 a.m.)


Review request for KDevelop.


Changes
-------

Correct diff uploaded.


Description
-------

This is related to https://git.reviewboard.kde.org/r/106463/.
So, CMakeJob is ported to use the class from given review.


Diffs (updated)
-----

  projectbuilders/cmakebuilder/cmakejob.h 6dd0a1a 
  projectbuilders/cmakebuilder/cmakejob.cpp 5e4f159 

Diff: http://git.reviewboard.kde.org/r/106465/diff/


Testing
-------

Manual testing + existing unit-tests.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120917/d2f61502/attachment.html>


More information about the KDevelop-devel mailing list