Review Request: BuilderJob: (follow-up) use BuilderJob instead of SequentiallyRunJobs in CMake/make builders
Ivan Shapovalov
intelfx100 at gmail.com
Mon Sep 17 07:56:24 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106462/
-----------------------------------------------------------
Review request for KDevelop.
Description
-------
(Related to https://git.reviewboard.kde.org/r/106461/.)
Use BuilderJob in builders to generate composite configure+build/build+install jobs.
This allows to avoid having nested composite jobs and generate uniform user-readable names of the composite jobs.
Diffs
-----
projectbuilders/cmakebuilder/cmakebuilder.cpp 2ad9d74
projectbuilders/makebuilder/makebuilder.cpp e0cdd02
Diff: http://git.reviewboard.kde.org/r/106462/diff/
Testing
-------
Manual testing, existing unit-tests. Works as expected.
Thanks,
Ivan Shapovalov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120917/9e3ab49b/attachment.html>
More information about the KDevelop-devel
mailing list