Review Request: Make it possible to rename files from a document change set

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106316/#review18463
-----------------------------------------------------------



language/codegen/documentchangeset.h
<http://git.reviewboard.kde.org/r/106316/#comment14583>

    this should also use IndexedString for the new name



language/codegen/documentchangeset.cpp
<http://git.reviewboard.kde.org/r/106316/#comment14584>

    same here, and while you are at it, please use a QHash



language/codegen/documentchangeset.cpp
<http://git.reviewboard.kde.org/r/106316/#comment14585>

    spaces around operators, add {\n ... \n}
    
    also, this is simpler imo:
    
    if (d->documentsRename.value(oldFile) != newName) {
      return false;
    }



language/codegen/documentchangeset.cpp
<http://git.reviewboard.kde.org/r/106316/#comment14587>

    spaces around operators



language/codegen/documentchangeset.cpp
<http://git.reviewboard.kde.org/r/106316/#comment14588>

    I'd prefer no spaces in <>



language/codegen/documentchangeset.cpp
<http://git.reviewboard.kde.org/r/106316/#comment14586>

    kill trailing spaces


- Milian Wolff


On Sept. 3, 2012, 1:50 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106316/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2012, 1:50 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Makes it possible to rename files before making changes.
> 
> This is useful because it makes it possible to rename the file before renaming the class. (another patch to be reviewed will be opened)
> 
> 
> Diffs
> -----
> 
>   language/codegen/documentchangeset.h 5d99d97 
>   language/codegen/documentchangeset.cpp 2c6f36f 
> 
> Diff: http://git.reviewboard.kde.org/r/106316/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120903/579b5cd9/attachment.html>