Review Request: When a class is renamed, rename the filename too, if it makes sense.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106317/#review18464
-----------------------------------------------------------


please add a unit test that verifies that the file is properly renamed. also test the case where a second class is in a file and it gets renamed, it shouldn't change the file name. similar for classes in .cpp files.


languages/cpp/codegen/simplerefactoring.cpp
<http://git.reviewboard.kde.org/r/106317/#comment14589>

    spacing + bracing: if(idx >= 0) {\n...\n}



languages/cpp/codegen/simplerefactoring.cpp
<http://git.reviewboard.kde.org/r/106317/#comment14590>

    add braces and use QFile::exists


- Milian Wolff


On Sept. 3, 2012, 2:53 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106317/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2012, 2:53 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Related to: https://git.reviewboard.kde.org/r/106316/
> 
> When a class is renamed, the filename will be renamed too the new name of the class.
> 
> Probably should change the #ifndef/#define guard, but not implemented.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codegen/simplerefactoring.cpp 3e4d7fa 
> 
> Diff: http://git.reviewboard.kde.org/r/106317/diff/
> 
> 
> Testing
> -------
> 
> I did it manually, for the moment.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120903/d9333610/attachment.html>