Review Request: Avoid endless loop in LA()

Jonathan Schmidt-Dominé devel at the-user.org
Wed Oct 31 16:03:21 UTC 2012


Hi!

I think it should be
set(PACKAGE_VERSION 1.0.1)
if("${PACKAGE_FIND_VERSION_MAJOR}" EQUAL 1)
   if("${PACKAGE_FIND_VERSION_MINOR}" EQUAL 0)
     set(PACKAGE_VERSION_COMPATIBLE 1)
     if("${PACKAGE_FIND_VERSION_PATCH}" EQUAL 1)
       set(PACKAGE_VERSION_EXACT 1)
     endif("${PACKAGE_FIND_VERSION_PATCH}" EQUAL 1)
  endif("${PACKAGE_FIND_VERSION_MINOR}" EQUAL 0)
endif("${PACKAGE_FIND_VERSION_MAJOR}" EQUAL 1)

in ConfigVersion.cmake. The version numbers in Config.cmake are just 
for convenience, if you want to access them manually. I changed the 
strings (pushed), version checks work. But I would be glad if somebody 
more experienced with releases could check that, too.

Regards
-- 
http://the-user.org/





More information about the KDevelop-devel mailing list