Review Request: Make StandardOutputView Work as Advertised on IOutputView

[David Narváez]

> On Oct. 31, 2012, 10:34 a.m., Milian Wolff wrote:
> > David, please try your plugin with these changes - does it work now?

Yes, it works, and all of the other issues I was having are now fixed (namely, creating a new view and raising the view when the output is updated), grat work!


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107126/#review21194
-----------------------------------------------------------


On Oct. 30, 2012, 8:42 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107126/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2012, 8:42 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> From IOutputView's documentation of the registerToolView method: "If there already exists a toolview with this title and type return the existing id"
> 
> 
> Diffs
> -----
> 
>   plugins/standardoutputview/standardoutputview.cpp 1a4cf8b 
> 
> Diff: http://git.reviewboard.kde.org/r/107126/diff/
> 
> 
> Testing
> -------
> 
> I'm writing a plugin that does not use a standard output view, and was crashing after using it twice without this patch. It is working more or less ok now (the crash is fixed, but there is an unrelated error elsewhere).
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121031/a31f170c/attachment.html>