Review Request: Make the VCS diff widget a self-contained dialog like the commit one.

[Aleix Pol Gonzalez]

> On Oct. 29, 2012, 2:48 p.m., Aleix Pol Gonzalez wrote:
> > Actually I'm unsure that we need this, this dialog is never shown because we have reviewpatch. Maybe we shouldn't have that?
> > 
> > Also probably it would be worth considering to crate a vcs ui plugin, so that the plugins only have to provide the UI they want to add (right now they all do throw the vcspluginhelper, and it doesn't seem a logical way to do it...)
> 
> Ivan Shapovalov wrote:
>     Anyway, some code is needed to handle the case when "IPatchReview* review == 0"... Of course, we may just print a nasty error message in that case.
>     
>     And regarding vcspluginhelper: I'm afraid that I don't understand you... and I'm not very confident with the overall system architecture - but I see that the vcspluginhelper is used just to provide the default context menu actions, and it seems to do that well.
>     // BTW, some plugins (say, Git) do not refer to the helper at all, but still get these default context menus - how's that accomplished?

It seems to do that well, but it's not easy to share code. For example, Sven wanted to add a global "annotate the current document" action yesterday and he couldn't do it without messing up the code.

Git inherits DistributedVcsPlugin that does that


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107112/#review21091
-----------------------------------------------------------


On Oct. 29, 2012, 2:26 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107112/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2012, 2:26 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> As stated in subject (VcsDiffWidget -> VcsDiffDialog and inherit from KDialog).
> Also stop the dialog from appearing in the vcs history dialog when there is a patchreview plugin available.
> 
> 
> Diffs
> -----
> 
>   plugins/subversion/kdevsvnplugin.cpp 560982e 
>   vcs/CMakeLists.txt 60fc7e9 
>   vcs/widgets/vcsdiffdialog.h PRE-CREATION 
>   vcs/widgets/vcsdiffdialog.cpp PRE-CREATION 
>   vcs/widgets/vcsdiffdialog.ui PRE-CREATION 
>   vcs/widgets/vcsdiffwidget.h aabc783 
>   vcs/widgets/vcsdiffwidget.cpp 54787b9 
>   vcs/widgets/vcsdiffwidget.ui ccde3a0 
>   vcs/widgets/vcseventwidget.cpp 5abad09 
> 
> Diff: http://git.reviewboard.kde.org/r/107112/diff/
> 
> 
> Testing
> -------
> 
> Manual.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121029/4a9a6eca/attachment.html>