Review Request: Git support: take care of submodule directories when committing non-recursively (the latter is the default&fixed behavior).

[Ivan Shapovalov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107115/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

Non-recursive operations in Git are handled by replacing a directory URL with URLs of all files (not directories) inside the given directory.
This is wrong when a change to a submodule directory (man git-submodule) is involved in commit. Actually, it does not make sense to "commit" all files inside the submodule directory as they are not a part of the parent repository.
And, actually, the commits are non-recursive by default (this is hardcoded) - so submodules can't be committed via GUI for now.

So, take list of all submodules in the repository and walk the source URL list copying all submodule items into the target list verbatim prior to invoking the directory->files expansion on the source list.


Diffs
-----

  plugins/git/gitplugin.h 1d13c5c 
  plugins/git/gitplugin.cpp 56efe2f 

Diff: http://git.reviewboard.kde.org/r/107115/diff/


Testing
-------

Existing unit-tests and manual testing.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121029/c9c5c4cf/attachment.html>