Review Request: Make the VCS diff widget a self-contained dialog like the commit one.

Ivan Shapovalov intelfx100 at gmail.com
Mon Oct 29 14:26:15 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107112/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

As stated in subject (VcsDiffWidget -> VcsDiffDialog and inherit from KDialog).
Also stop the dialog from appearing in the vcs history dialog when there is a patchreview plugin available.


Diffs
-----

  plugins/subversion/kdevsvnplugin.cpp 560982e 
  vcs/CMakeLists.txt 60fc7e9 
  vcs/widgets/vcsdiffdialog.h PRE-CREATION 
  vcs/widgets/vcsdiffdialog.cpp PRE-CREATION 
  vcs/widgets/vcsdiffdialog.ui PRE-CREATION 
  vcs/widgets/vcsdiffwidget.h aabc783 
  vcs/widgets/vcsdiffwidget.cpp 54787b9 
  vcs/widgets/vcsdiffwidget.ui ccde3a0 
  vcs/widgets/vcseventwidget.cpp 5abad09 

Diff: http://git.reviewboard.kde.org/r/107112/diff/


Testing
-------

Manual.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121029/cfb7792e/attachment.html>


More information about the KDevelop-devel mailing list