Review Request: Fix sporadic crash when parsing files

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107035/#review21046
-----------------------------------------------------------


This review has been submitted with commit 806e519584f94eb7e00333c47a9945764e5905c3 by Milian Wolff to branch master.

- Commit Hook


On Oct. 25, 2012, 7:20 p.m., Maciej Cencora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107035/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2012, 7:20 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Sometimes we pass a reference to temporary variable (i.e. AbstractType::Ptr() ) as _dataType param to DeclarationChecker constructor.
> It is later used in operator() member function, while this temp variable does not exist anymore resulting in SIGSEGV.
> Fix this by storing copy of dataType instead of const ref inside DeclarationChecker.
> 
> 
> Diffs
> -----
> 
>   language/duchain/topducontextutils.h 349ba50 
> 
> Diff: http://git.reviewboard.kde.org/r/107035/diff/
> 
> 
> Testing
> -------
> 
> None. How do I run all UTs for kdevplatform?
> 
> Update:
> Unit test run, result the same as without a patch.
> 
> I could try writing an UT, but I'd need some help.
> What should be unit tested here? The TestPtr class that it doesn't store a ref but makes a copy?
> 
> 
> Thanks,
> 
> Maciej Cencora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121028/743aac15/attachment.html>