Review Request: Fix C++ completion bug: don't insert "::::" when completing namespaces in some situations

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107069/#review20997
-----------------------------------------------------------

Ship it!


neat, please merge into 4.4 branch

- Milian Wolff


On Oct. 27, 2012, 10:48 a.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107069/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2012, 10:48 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> If you have something like
> Foobar::var;
> then you replace Foobar by another namespace (or just complete
> it again by pressing Ctrl+Space Enter with the cursor somewhere
> in the word), then you would have two double-colons. This patch
> fixes that and also adds a unit test to verify the changes.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codecompletion/item.cpp 42ccc55 
>   languages/cpp/tests/test_cppcodecompletion.h 69a7586 
>   languages/cpp/tests/test_cppcodecompletion.cpp fb67404 
> 
> Diff: http://git.reviewboard.kde.org/r/107069/diff/
> 
> 
> Testing
> -------
> 
> Tested by hand, and verified by a unit test.
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121027/83c83bf4/attachment.html>