Review Request: Fix sporadic crash when parsing files

Maciej Cencora m.cencora at gmail.com
Thu Oct 25 13:42:12 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107035/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

Sometimes we pass a reference to temporary variable (i.e. AbstractType::Ptr() ) as _dataType param to DeclarationChecker constructor.
It is later used in operator() member function, while this temp variable does not exist anymore resulting in SIGSEGV.
Fix this by storing copy of dataType instead of const ref inside DeclarationChecker.


Diffs
-----

  language/duchain/topducontextutils.h 349ba50 

Diff: http://git.reviewboard.kde.org/r/107035/diff/


Testing
-------

None. How do I run all UTs for kdevplatform?


Thanks,

Maciej Cencora

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121025/edaa0329/attachment.html>


More information about the KDevelop-devel mailing list