Review Request: Custom Make: Ignore more temporary files from project
Andreas Pakulat
apaku at gmx.de
Fri Oct 19 11:41:46 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106946/#review20572
-----------------------------------------------------------
Ship it!
Looks ok, but even better would be to get the custommake manager to use the abstractfilemanagerplugin class to handle the basics (that one is shared among different managers already and provides some useful filtering IIRC)
- Andreas Pakulat
On Oct. 19, 2012, 9:13 a.m., Maciej Cencora wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106946/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2012, 9:13 a.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> Custom Make: Ignore more temporary files from project
>
>
> Diffs
> -----
>
> projectmanagers/custommake/custommakemanager.cpp 4a457e4
>
> Diff: http://git.reviewboard.kde.org/r/106946/diff/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Maciej Cencora
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121019/3efcea75/attachment.html>
More information about the KDevelop-devel
mailing list