Review Request: Improve finding of QJSON

Milian Wolff mail at milianw.de
Thu Oct 18 07:43:24 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106934/#review20534
-----------------------------------------------------------


theoretically all for it, but I think we now need to handle the debian failure as well. see: https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/f19fd8d35c505d96fdde29af42dfe506d6d7c93e

- Milian Wolff


On Oct. 17, 2012, 8:19 p.m., Ben Cooksley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106934/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2012, 8:19 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Updates FindQJSON.cmake to the latest available version - which allows it to use a QJSONConfig.cmake file if available (which is more accurate).
> Tweak the include_directories statement for QJSON so that the tests have it available as well.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindQJSON.cmake 002084a 
>   plugins/reviewboard/CMakeLists.txt 468c0d9 
> 
> Diff: http://git.reviewboard.kde.org/r/106934/diff/
> 
> 
> Testing
> -------
> 
> Builds now on build.kde.org.
> 
> 
> Thanks,
> 
> Ben Cooksley
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121018/b7e7cc0d/attachment.html>


More information about the KDevelop-devel mailing list