Review Request: OpenWith - configuration dialog

[Przemek Czekaj]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106388/
-----------------------------------------------------------

(Updated Oct. 17, 2012, 12:43 p.m.)


Review request for KDevelop.


Changes
-------

Improved variable naming, and follow by suggest in comments to first patch. Thanks.


Description
-------

Added a configuration dialog to the context menu.

@edit
give me few days, I will improve patch.


This addresses bug 287764.
    http://bugs.kde.org/show_bug.cgi?id=287764


Diffs (updated)
-----

  plugins/openwith/CMakeLists.txt 8742aeb 
  plugins/openwith/openwithconfig.h PRE-CREATION 
  plugins/openwith/openwithconfig.cpp PRE-CREATION 
  plugins/openwith/openwithconfig.ui PRE-CREATION 
  plugins/openwith/openwithplugin.h 809a0e8 
  plugins/openwith/openwithplugin.cpp 69404ef 

Diff: http://git.reviewboard.kde.org/r/106388/diff/


Testing
-------

Compiled, and local install. Tested by hand.


Screenshots
-----------

OpenWith context menu
  http://git.reviewboard.kde.org/r/106388/s/722/
Openwith dialog - internal option
  http://git.reviewboard.kde.org/r/106388/s/723/
Open with - selectable list
  http://git.reviewboard.kde.org/r/106388/s/724/


Thanks,

Przemek Czekaj

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121017/8adeee6b/attachment.html>