Review Request: Fix build on PPC

[Milian Wolff]

> On Oct. 15, 2012, 3:51 p.m., Milian Wolff wrote:
> > while I'm OK with that, I wonder whether not maybe Kasten itself should have a proper define to check that... anyhow, just commit it
> 
> Andreas Pakulat wrote:
>     Well, I guess thats whats happening already and hence the factory etc. is not available causing kdevelop to fail to build with such a Kasten library. Whats not so nice IMO is that this is based on endianess only, it would be nicer to keep that part in kasten and have kasten advertise via cmake variables which stuff was included when it was built or via a header which sets defines like NO_STRUCTURES_VIEW. Then kdevelop would only include the structures factory if it was included in kasten, no matter what reason there was to not include it (there may be other reasons than just endinaness).
> 
> Michael Palimaka wrote:
>     So is that a yes or a no? :-)
>     
>     (I note that the only reason for checking endianness here is because that's what kasten does)

Note: I actually meant exactly what Andreas suggests, I was just too lazy to explain myself properly ;-) I'll notify Friedrich about that and hope to see him fix this properly.

Feel free to push your buildfix to kdevelop for now.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106812/#review20390
-----------------------------------------------------------


On Oct. 12, 2012, 3:11 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106812/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2012, 3:11 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This patch (from Fedora) disables the structures tool on big endian systems, as the required library is not supported:
> 
> # temporary check for broken code in the Structures tool with bigendianness
> include(TestBigEndian)
> test_big_endian(BIG_ENDIAN)
> if (BIG_ENDIAN)
>   set( NO_STRUCTURES_TOOL TRUE )
> endif (BIG_ENDIAN)
> 
> 
> Diffs
> -----
> 
>   utils/okteta/oktetaplugin.cpp 5691959629f9fc8a6a9a8f518f6c8b9bf63e9cf4 
> 
> Diff: http://git.reviewboard.kde.org/r/106812/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121017/8cc85823/attachment.html>