Review Request: Add filter to pick session dialog

[Niko Sams]

> On Oct. 14, 2012, 10:43 p.m., Aleix Pol Gonzalez wrote:
> > For this, you can use KFilterProxySearchLine, it probably be less code and maybe you won't have to expose the line edit as a constructor parameter, I guess...
> 
> Niko Sams wrote:
>     hm, doesn't save much code. It also doesn't handle selection with up/down. But I'll change to use that class.

Oh, and this class has one downside: it buffers  textchanges; so the filter is applied after 300ms.

While this perfectly makes sense for large lists it's rather annoying here. I'd prefer to not use it.


- Niko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106848/#review20346
-----------------------------------------------------------


On Oct. 14, 2012, 2:08 p.m., Niko Sams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106848/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2012, 2:08 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This patch adds a QLineEdit below sessions view that filters the list of sessions. Up and Down keys are handled so you can navigate using them in the list without having to focus it.
> 
> 
> Diffs
> -----
> 
>   shell/sessioncontroller.cpp c9fac67 
> 
> Diff: http://git.reviewboard.kde.org/r/106848/diff/
> 
> 
> Testing
> -------
> 
> run kdevelop -ps
> 
> 
> Screenshots
> -----------
> 
> Pick Session Filter
>   http://git.reviewboard.kde.org/r/106848/s/770/
> 
> 
> Thanks,
> 
> Niko Sams
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121015/56b8f54f/attachment.html>