Review Request: Function specialization support

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106765/#review20367
-----------------------------------------------------------


two small issues, otherwise fine with me assuming you tested it also on code that uses e.g. boost, stl or similar and it didn't crash


languages/cpp/cppduchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/106765/#comment16112>

    you could reuse funDecl from above, no? would make the whole code much less verbose



languages/cpp/cppduchain/tests/test_expressionparser.cpp
<http://git.reviewboard.kde.org/r/106765/#comment16113>

    could you maybe add some comments here that explain how these things should be interpreted for the template-inhibited people like me? :)
    
    you could also think about splitting the test up, maybe even using QTest's _data functionality?
    
    but well, this should suffice already:
    
    // this is the base
    "class ...\n"
    // this should be ...
    "template<> ...\n"
    // ...


- Milian Wolff


On Oct. 8, 2012, 12:33 p.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106765/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2012, 12:33 p.m.)
> 
> 
> Review request for KDevelop, Milian Wolff and David Nolden.
> 
> 
> Description
> -------
> 
> Properly support function specializations. Depends on kdevplatform patch. Add and enable tests.
> 
> 
> This addresses bug 183614.
>     http://bugs.kde.org/show_bug.cgi?id=183614
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppduchain/declarationbuilder.h cf9e7da 
>   languages/cpp/cppduchain/declarationbuilder.cpp a0469de 
>   languages/cpp/cppduchain/expressionvisitor.cpp cbe00ee 
>   languages/cpp/cppduchain/tests/test_duchain.cpp fb3459b 
>   languages/cpp/cppduchain/tests/test_expressionparser.h 55f5429 
>   languages/cpp/cppduchain/tests/test_expressionparser.cpp 5ac96fb 
> 
> Diff: http://git.reviewboard.kde.org/r/106765/diff/
> 
> 
> Testing
> -------
> 
> Automated and manual.
> 
> 
> Thanks,
> 
> Olivier Jean de Gaalon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121015/0c8d2782/attachment.html>