Review Request: Refactor session loading/parsing.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106803/#review20282
-----------------------------------------------------------

Ship it!


assuming the exporting is a non-issue, I'm all for it.


shell/session.h
<http://git.reviewboard.kde.org/r/106803/#comment16035>

    does this also need to be exported? or not?


- Milian Wolff


On Oct. 12, 2012, 7:27 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106803/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2012, 7:27 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Unify code that reads "sessionrc" between session.cpp and sessioncontroller.cpp (as stated in an in-code TODO statement).
> 
> 
> Diffs
> -----
> 
>   shell/session.h 342e4c6 
>   shell/session.cpp 526c013 
>   shell/sessioncontroller.h 551894d 
>   shell/sessioncontroller.cpp c9fac67 
> 
> Diff: http://git.reviewboard.kde.org/r/106803/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests, manual testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121013/86032583/attachment.html>