Review Request: Fix bug in outputfilteringstrategies for identifying krazy2 error lines

Milian Wolff mail at milianw.de
Thu Oct 11 17:16:27 UTC 2012



> On Oct. 4, 2012, 10 p.m., Milian Wolff wrote:
> > please push into the 1.4 branch
> > 
> > thanks!
> 
> Morten Volden wrote:
>     Millian, you do mean master, right? This patch requires the output filtering strategy refactoring, and as far as I can see that is not in 1.4.

ah yes of course


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106690/#review19933
-----------------------------------------------------------


On Oct. 4, 2012, 8:56 p.m., Morten Volden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106690/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2012, 8:56 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This patch fixes a small bug in the regular expressions for finding error lines in krazy2 output. 
> 
> 
> Diffs
> -----
> 
>   outputview/outputfilteringstrategies.cpp 2ea055d 
>   outputview/tests/filteringstrategytest.cpp 2057875 
>   outputview/tests/testlinebuilderfunctions.h f0d5529 
> 
> Diff: http://git.reviewboard.kde.org/r/106690/diff/
> 
> 
> Testing
> -------
> 
> Extended existing unittest with two new cases. 
> 
> 
> Thanks,
> 
> Morten Volden
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121011/2dafda45/attachment.html>


More information about the KDevelop-devel mailing list