Review Request: Bugfix Signature Assistant, add tests

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106667/#review19949
-----------------------------------------------------------


This review has been submitted with commit 9ae3c9a4e51cf192a61c0a43b41d7163206baa15 by Olivier JG to branch master.

- Commit Hook


On Oct. 1, 2012, 1:22 p.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106667/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2012, 1:22 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Fix signature assistant default argument assignment, add tests (also for renameAssistant).
> Note that the tests require a patch to kdevplatform to disable the source formatter.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codegen/codeassistant.h d4284a2 
>   languages/cpp/codegen/renameaction.h 5455777 
>   languages/cpp/codegen/renameaction.cpp 0336100 
>   languages/cpp/codegen/signatureassistant.cpp 4447572 
>   languages/cpp/tests/CMakeLists.txt 24d9597 
>   languages/cpp/tests/test_cppassistants.h PRE-CREATION 
>   languages/cpp/tests/test_cppassistants.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106667/diff/
> 
> 
> Testing
> -------
> 
> Lots.
> 
> 
> Thanks,
> 
> Olivier Jean de Gaalon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121005/480d6773/attachment.html>