Review Request: Fixed GPF for CMake string() commands with incorrect argument count

Michal Malek michalm at jabster.pl
Mon Oct 1 16:27:33 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106672/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

CMake project manager parser doesn't check number of arguments when it parses string() function with commands CONFIGURE, TOUPPER, TOLOWER and LENGTH. This results in GPF when for some reason too few arguments is provided for these commands. This patch adds missing checks.


Diffs
-----

  projectmanagers/cmake/parser/cmakeast.cpp bff718c618669370aad8856673ef584e60e3c314 

Diff: http://git.reviewboard.kde.org/r/106672/diff/


Testing
-------


Thanks,

Michal Malek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121001/04f38610/attachment.html>


More information about the KDevelop-devel mailing list