Review Request: Json cpp tests

Milian Wolff mail at milianw.de
Thu Nov 29 11:03:32 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107491/#review22749
-----------------------------------------------------------

Ship it!


Also a ship it besides a small cmake change that will probably need more changes in KDevplatform.


languages/cpp/tests/CMakeLists.txt
<http://git.reviewboard.kde.org/r/107491/#comment17384>

    this should be ${KDEVPLATFORM_JSONTESTS_LIBRARIES}
    
    Probably this will need more changes to the CMakeLists.txt in kdevplatform. If in doubt, ask Andreas Pakulat about what to do.


- Milian Wolff


On Nov. 28, 2012, 4:02 p.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107491/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2012, 4:02 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> New test for json-annotated cpp files.
> Cpp-specific json tests.
> 
> Check in particular the cmake changes.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/tests/CMakeLists.txt 4f75de0 
>   languages/cpp/tests/cppjsontests.h PRE-CREATION 
>   languages/cpp/tests/cpptestfiles/alljsontests.cpp PRE-CREATION 
>   languages/cpp/tests/test_cppfiles.h PRE-CREATION 
>   languages/cpp/tests/test_cppfiles.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107491/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olivier Jean de Gaalon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121129/dc054a61/attachment.html>


More information about the KDevelop-devel mailing list