Review Request: Json cpp tests

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107491/#review22693
-----------------------------------------------------------


Looks cool, but I think I found three smallish issues


languages/cpp/tests/CMakeLists.txt
<http://git.reviewboard.kde.org/r/107491/#comment17342>

    this should not be required, you can access the source dir from the tests in the binary dir. Look at kdevelop/projectmanagers/cmake/tests/CMakeLists.txt and its paths.h.cmake.



languages/cpp/tests/test_cppfiles.cpp
<http://git.reviewboard.kde.org/r/107491/#comment17343>

    use TestCore::shutdown();



languages/cpp/tests/test_cppfiles.cpp
<http://git.reviewboard.kde.org/r/107491/#comment17344>

    remove linebreak:
    
    foreach (...) {\n  ...



languages/cpp/tests/test_cppfiles.cpp
<http://git.reviewboard.kde.org/r/107491/#comment17345>

    this should probably use kdevplatform/tests/testfile.h, no?


- Milian Wolff


On Nov. 27, 2012, 1:52 p.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107491/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2012, 1:52 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> New test for json-annotated cpp files.
> Cpp-specific json tests.
> 
> Check in particular the cmake changes.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/tests/CMakeLists.txt 4f75de0 
>   languages/cpp/tests/cppjsontests.h PRE-CREATION 
>   languages/cpp/tests/cpptestfiles/alljsontests.cpp PRE-CREATION 
>   languages/cpp/tests/test_cppfiles.h PRE-CREATION 
>   languages/cpp/tests/test_cppfiles.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107491/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olivier Jean de Gaalon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121128/943f487d/attachment.html>