Review Request: Implicitly use default environment group when empty group name is passed.

Milian Wolff mail at milianw.de
Mon Nov 26 20:17:52 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107114/#review22599
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On Oct. 29, 2012, 2:47 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107114/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2012, 2:47 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> In the EnvironmentGroupList, implicitly take the group to be default if empty group name is passed.
> Reason: at least the CMake support does not use the designated default group method (EnvironmentGroupList::defaultGroup()). I guess that many other plugins don't do that either.
> 
> 
> Diffs
> -----
> 
>   util/environmentgrouplist.cpp a8484f6 
> 
> Diff: http://git.reviewboard.kde.org/r/107114/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests and manual testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121126/4caf6053/attachment.html>


More information about the KDevelop-devel mailing list