Review Request: Fix cmakeloadprojecttest work

[Sergey Vidyuk]

> On Nov. 26, 2012, 2:55 a.m., Aleix Pol Gonzalez wrote:
> > xD I'm ok with the change, but I'd have expected to see a Ship it before the commit... :P

I was also expecting request ro send formatted patch with fixed misprintings in the description :)


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107453/#review22535
-----------------------------------------------------------


On Nov. 24, 2012, 9:36 p.m., Sergey Vidyuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107453/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2012, 9:36 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Looks like it was broken by 6c6b4fe7f4b62a8c03dcd1cefaa5fda2035f6def.
> There are two issues related to that commit:
>  * "test" target is renamed into "testkde4app" in the
> kde4app/CMakeLists.txt and not renamed in the test code.
>  * Disapeared target "buildtests" is generated only when
> KDE4_BUILD_TESTS is False according to the kde4_add_unit_test macro
> implementation. Now it set tot True exolicitely to elliminate dependency
> on developer environment.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/tests/cmakeloadprojecttest.cpp 6612dd2 
> 
> Diff: http://git.reviewboard.kde.org/r/107453/diff/
> 
> 
> Testing
> -------
> 
> Run modified unit test successfully
> 
> 
> Thanks,
> 
> Sergey Vidyuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121126/e28c7f76/attachment.html>