Review Request: Fix cmakeloadprojecttest work

Sergey Vidyuk sir.vestnik at gmail.com
Sat Nov 24 21:36:50 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107453/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

Looks like it was broken by 6c6b4fe7f4b62a8c03dcd1cefaa5fda2035f6def.
There are two issues related to that commit:
 * "test" target is renamed into "testkde4app" in the
kde4app/CMakeLists.txt and not renamed in the test code.
 * Disapeared target "buildtests" is generated only when
KDE4_BUILD_TESTS is False according to the kde4_add_unit_test macro
implementation. Now it set tot True exolicitely to elliminate dependency
on developer environment.


Diffs
-----

  projectmanagers/cmake/tests/cmakeloadprojecttest.cpp 6612dd2 

Diff: http://git.reviewboard.kde.org/r/107453/diff/


Testing
-------

Run modified unit test successfully


Thanks,

Sergey Vidyuk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121124/9daf6f7b/attachment.html>


More information about the KDevelop-devel mailing list