Review Request: Fix kdevelop building with Clang (CFLAGS issue)

[Andreas Pakulat]

> On Nov. 21, 2012, 1:54 p.m., Andreas Pakulat wrote:
> > CMakeLists.txt, line 50
> > <http://git.reviewboard.kde.org/r/107405/diff/2/?file=95637#file95637line50>
> >
> >     Instead of doing all this globally, why not also move it to the place that actually uses unordered_map? That also avoids other people adding C++0x code accidentally.
> 
> Milian Wolff wrote:
>     No, since we get some free lunch when compiling in C++11 mode. Also I want to move to C++11 with KDevelop 4.6 (I'll bring that up on the mailing list).

Then you can move this to a global place once master moves to 4.6. In fact if this is done on such a global level you should immediately drop support for all compilers not understanding it.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107405/#review22308
-----------------------------------------------------------


On Nov. 21, 2012, 1:37 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107405/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2012, 1:37 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> (This is a follow-up to https://git.reviewboard.kde.org/r/107363/)
> 
> Current CMakeLists.txt sets c++0x mode by using add_definitions(). This is not correct as these definitions also propagate to compilation of plain C files.
> Replace add_definitions() with modification CMAKE_CXX_FLAGS property.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6150ddd 
> 
> Diff: http://git.reviewboard.kde.org/r/107405/diff/
> 
> 
> Testing
> -------
> 
> Tested building on both GCC 4.7.2 and Clang 3.1.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121121/1bcbfd42/attachment.html>