Review Request: Fix kdevplatform building with Clang (CFLAGS issue)

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107363/#review22309
-----------------------------------------------------------



CMakeLists.txt
<http://git.reviewboard.kde.org/r/107363/#comment17144>

    As with the kdevelop change I think it would be better to set a target property on the targets that actually need this flag.


- Andreas Pakulat


On Nov. 21, 2012, 1:34 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107363/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2012, 1:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Current CMakeLists.txt sets c++0x mode by using add_definitions(). This is not correct as these definitions also propagate to compilation of plain C files.
> Replace add_definitions() with modification CMAKE_CXX_FLAGS property.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 63e1cc4 
> 
> Diff: http://git.reviewboard.kde.org/r/107363/diff/
> 
> 
> Testing
> -------
> 
> Tested building on both GCC 4.7.2 and Clang 3.1.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121121/2bad30a4/attachment.html>