Review Request: Fix kdevelop building with Clang (CFLAGS issue)
Ivan Shapovalov
intelfx100 at gmail.com
Wed Nov 21 13:37:20 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107405/
-----------------------------------------------------------
Review request for KDevelop.
Summary (updated)
-----------------
Fix kdevelop building with Clang (CFLAGS issue)
Description (updated)
-------
(This is a follow-up to https://git.reviewboard.kde.org/r/107363/)
Current CMakeLists.txt sets c++0x mode by using add_definitions(). This is not correct as these definitions also propagate to compilation of plain C files.
Replace add_definitions() with modification CMAKE_CXX_FLAGS property.
Diffs (updated)
-----
CMakeLists.txt 6150ddd
Diff: http://git.reviewboard.kde.org/r/107405/diff/
Testing (updated)
-------
Tested building on both GCC 4.7.2 and Clang 3.1.
Thanks,
Ivan Shapovalov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121121/4baaf019/attachment.html>
More information about the KDevelop-devel
mailing list