Review Request: Add Switch to buddy plugin which always swichting between cpp and header file [2/2]

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107311/#review22134
-----------------------------------------------------------


generally looks good, have you run the unit tests in languages/cpp/tests/test_buddies.cpp? Can you make sure it is up 2 date and tests everything you add here?


languages/cpp/cpplanguagesupport.cpp
<http://git.reviewboard.kde.org/r/107311/#comment17016>

    Considering that this is not called in performance critical sections, I'd prefer if you do not make these vars global (and not even static at that).
    
    Rather call them in the function as needed, which would also allow the user to update the mimetypes and have the affect in kdevelop instantaneously without needing a restart



languages/cpp/cpplanguagesupport.cpp
<http://git.reviewboard.kde.org/r/107311/#comment17017>

    can you fix the inconsistent spacing while you are at it? "if_(" please



languages/cpp/cpplanguagesupport.cpp
<http://git.reviewboard.kde.org/r/107311/#comment17018>

    no linebreak here please



languages/cpp/cpplanguagesupport.cpp
<http://git.reviewboard.kde.org/r/107311/#comment17019>

    neither here


- Milian Wolff


On Nov. 16, 2012, 1:38 p.m., André Stein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107311/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2012, 1:38 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Second part of request 107310. This implements the C++ specific adaptions in Kdevelop. Must be merged together!
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cpplanguagesupport.h 4053b18 
>   languages/cpp/cpplanguagesupport.cpp 60f8a63 
> 
> Diff: http://git.reviewboard.kde.org/r/107311/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> André Stein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121117/b18418e4/attachment.html>