Review Request: Feature: Lookahead Match Completions

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107200/#review22056
-----------------------------------------------------------



languages/cpp/codecompletion/context.cpp
<http://git.reviewboard.kde.org/r/107200/#comment16980>

    please add braces here



languages/cpp/codecompletion/context.cpp
<http://git.reviewboard.kde.org/r/107200/#comment16981>

    const& IndexedType



languages/cpp/codecompletion/context.cpp
<http://git.reviewboard.kde.org/r/107200/#comment16982>

    const& for DeclAccessPair


- Milian Wolff


On Nov. 4, 2012, 5:54 p.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107200/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2012, 5:54 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Add a new feature which looks though existing completions for instances of classes, and looks in those classes for declarations which match the desired type. In other words:
> ------------
> struct foo
> {
>   int a;
> };
> int main()
> {
>   foo myFoo;
>   int myInt = //offers myFoo.a
> }
> ------------
> 
> In my testing, in the worst case (large file, lots of visible declarations), this takes under 60 ms for me. In most cases it will probably be much less.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codecompletion/context.h b6fb017 
>   languages/cpp/codecompletion/context.cpp 6d9c3cc 
>   languages/cpp/codecompletion/item.h c220753 
>   languages/cpp/codecompletion/item.cpp 2514f9a 
>   languages/cpp/tests/test_cppcodecompletion.h 574de0f 
>   languages/cpp/tests/test_cppcodecompletion.cpp 88a0df7 
> 
> Diff: http://git.reviewboard.kde.org/r/107200/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests, usage.
> 
> 
> Thanks,
> 
> Olivier Jean de Gaalon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121115/18c1afe4/attachment.html>