Review Request: Determine template type by reading a desktop file

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107304/#review22053
-----------------------------------------------------------



plugins/filetemplates/filetemplatesplugin.cpp
<http://git.reviewboard.kde.org/r/107304/#comment16977>

    duplicated code, please just save the url of item->file() or the editorcontext's url and then operate on that



plugins/filetemplates/filetemplatesplugin.cpp
<http://git.reviewboard.kde.org/r/107304/#comment16978>

    add a maximum limit of, say, 5 here


- Milian Wolff


On Nov. 12, 2012, 8:30 p.m., Miha Čančula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107304/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2012, 8:30 p.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Description
> -------
> 
> The filetemplates plugin recursively scans the file's directory and its parents for a template description file. The determined template type is used to add a context menu action, as well as for the template preview. The context menu action appears in the project manager's and editor's context menu. 
> 
> 
> Diffs
> -----
> 
>   plugins/filetemplates/filetemplatesplugin.h 18c9b20a02579ea7e8312f10619ba5e28ff04886 
>   plugins/filetemplates/filetemplatesplugin.cpp 8912c120a32387647c107031d713549989bfe5b2 
>   plugins/filetemplates/templatepreview.h 77e049f1300c0768f5d436635e356fa7d63e8f48 
>   plugins/filetemplates/templatepreview.cpp f28089e0ab5f8e7ae6c3dc48483eea7df3b0f34b 
> 
> Diff: http://git.reviewboard.kde.org/r/107304/diff/
> 
> 
> Testing
> -------
> 
> Locally, with both project templates and file templates
> 
> 
> Screenshots
> -----------
> 
> Context menu of a project template file in project manager
>   http://git.reviewboard.kde.org/r/107304/s/823/
> Context menu when editing a class template
>   http://git.reviewboard.kde.org/r/107304/s/824/
> 
> 
> Thanks,
> 
> Miha Čančula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121115/71dfd268/attachment.html>