Review Request: Make the uses widget nicer.

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107296/#review22042
-----------------------------------------------------------


Looks nicer and nicer, but I have a few suggestions:

# Fonts

I am not fond of the mix of italics and bold though: it makes it harder to focus on the content I think. Have you tried getting rid of them?

# Expand / Collapse links

It may also look a bit more tidy with [-] and [+] symbols on the left of the text instead of [Expand], [Collapse] links. You can draw those with something like this (from QTreeView code):

    QStyleOptionViewItem opt;
    opt.rect = ...
    opt.state = QStyle::State_Children;
    if (expanded) {
        opt.state |= QStyle::State_Open;
    }

    style()->drawPrimitive(QStyle::PE_IndicatorBranch, &opt, painter, this);

# Wording

The "%d uses" string should be harmonized I think:

Right now text of top-level lines is:

    %d uses: /foo/bar/baz.cpp

Whereas text of context lines is:

    In context Class::method(...): %d uses

I would suggest using "%d uses in %s" for both top-level and context lines.

Assuming "context" is not ambiguous, "In context Class::method(...)" can be simplified to "In Class::method(...)"

# Alignments

I think it would look nicer if the left of the purple bullets were aligned with the left of the "In context" string.


- Aurélien Gâteau


On Nov. 14, 2012, 9:19 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107296/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2012, 9:19 p.m.)
> 
> 
> Review request for KDevelop, KDE Usability and Milian Wolff.
> 
> 
> Description
> -------
> 
> TL;DR: Look at the screenshots below. :)
> 
> Make the uses widget nicer.
> 
> Main changes include:
>  * Fix contexts not being clickable (they were clickable but didn't work)
>  * Remove the blue arrows; all widgets are expanded by default and can
>    be collapsed with a small link in the text instead. This operation is
>    not common enough to justify such a huge ugly button.
>    (The main problem with the button was that it looked ugly, tough)
>  * Contexts without actual uses are always sorted last.
>  * Add some nice icons to the list.
>  * Remove all the ugly frames.
>  * Make text displaying code use a fixed-width font.
>  * Make the tooltip use a fixed-width font too, make it smaller (just 2
>    lines of context instead of 3), and highlight the line with the use
>    by making it bold-face.
>  * Re-format and rename all the widget headers to be more readable
>    and look nicer.
> 
> I will add a few comments to the patch to explain what I was doing.
> 
> Oh and also, I had that impression for quite a while now, but right now I'm pretty sure the find uses feature is broken in some way. Just look at the screenshots: it found way more occurences in the first screenshot than in the second (which happened after a reparse of some projects). And this has nothing to do with my changes. :)
> 
> 
> Diffs
> -----
> 
>   language/duchain/navigation/useswidget.h ec0440e 
>   language/duchain/navigation/useswidget.cpp 8c01e7c 
>   shell/projectcontroller.cpp 6168066 
> 
> Diff: http://git.reviewboard.kde.org/r/107296/diff/
> 
> 
> Testing
> -------
> 
> Manual testing; no functional changes were done except for the context link fix.
> 
> 
> Screenshots
> -----------
> 
> Comparsion between the old and the new uses widget.
>   http://git.reviewboard.kde.org/r/107296/s/821/
> The new useswidget after the latest updates
>   http://git.reviewboard.kde.org/r/107296/s/822/
> Third version; the header line updates while uses are being searched
>   http://git.reviewboard.kde.org/r/107296/s/832/
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121115/f470916c/attachment.html>