Review Request: Make the uses widget nicer.

[Sven Brauch]

> On Nov. 13, 2012, 8:44 a.m., Torbjoern Klatt wrote:
> > First of all: The reworked widget looks waaaay better and actually becomes really useful now :D (I wasn't aware, that it wasn't useful before, though)
> > 
> > I've got one little wish as a user: Would it be possible to add some "collapse/expand all" button or item in the context menu? I know, it's unrelated to your changes but could be added while your'r at it anyway.
> > 
> > Thank you a lot for this improvement. I'm already using it in production :)
> 
> Sven Brauch wrote:
>     Yes, I have already considered this. Should be easy; I'll have a look at it later.
> 
> Aleix Pol Gonzalez wrote:
>     What about having it always expanded? It doesn't look like it's a user will want to spend time configuring what it looks like. This would reduce some complexity in the view.

I wanted to do that first but then I dismissed it, since it's a real loss of functionality (it makes it more difficult to quickly get an overview about in which files the object occurs).

I know it's always very difficult to judge whether a UI is complicated or not if you've been working with it for a long time, but in this case I think it's not particularily hard to grasp what it does. Most of the features are obvious, and it's easy to just ignore them if you're only interested in the contents.

Fact is, I think we'll have quite a few disappointed people when we remove if we remove this button (don't tell adymo I said this!). :)


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107296/#review21916
-----------------------------------------------------------


On Nov. 14, 2012, 5:09 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107296/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2012, 5:09 p.m.)
> 
> 
> Review request for KDevelop, KDE Usability and Milian Wolff.
> 
> 
> Description
> -------
> 
> TL;DR: Look at the screenshots below. :)
> 
> Make the uses widget nicer.
> 
> Main changes include:
>  * Fix contexts not being clickable (they were clickable but didn't work)
>  * Remove the blue arrows; all widgets are expanded by default and can
>    be collapsed with a small link in the text instead. This operation is
>    not common enough to justify such a huge ugly button.
>    (The main problem with the button was that it looked ugly, tough)
>  * Contexts without actual uses are always sorted last.
>  * Add some nice icons to the list.
>  * Remove all the ugly frames.
>  * Make text displaying code use a fixed-width font.
>  * Make the tooltip use a fixed-width font too, make it smaller (just 2
>    lines of context instead of 3), and highlight the line with the use
>    by making it bold-face.
>  * Re-format and rename all the widget headers to be more readable
>    and look nicer.
> 
> I will add a few comments to the patch to explain what I was doing.
> 
> Oh and also, I had that impression for quite a while now, but right now I'm pretty sure the find uses feature is broken in some way. Just look at the screenshots: it found way more occurences in the first screenshot than in the second (which happened after a reparse of some projects). And this has nothing to do with my changes. :)
> 
> 
> Diffs
> -----
> 
>   language/duchain/navigation/useswidget.h ec0440e 
>   language/duchain/navigation/useswidget.cpp 8c01e7c 
>   shell/projectcontroller.cpp 6168066 
> 
> Diff: http://git.reviewboard.kde.org/r/107296/diff/
> 
> 
> Testing
> -------
> 
> Manual testing; no functional changes were done except for the context link fix.
> 
> 
> Screenshots
> -----------
> 
> Comparsion between the old and the new uses widget.
>   http://git.reviewboard.kde.org/r/107296/s/821/
> The new useswidget after the latest updates
>   http://git.reviewboard.kde.org/r/107296/s/822/
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121114/328ebaf4/attachment.html>