Review Request: Make the uses widget nicer.

[Sven Brauch]

> On Nov. 12, 2012, 1:54 a.m., Aleix Pol Gonzalez wrote:
> > language/duchain/navigation/useswidget.cpp, line 350
> > <http://git.reviewboard.kde.org/r/107296/diff/2/?file=94643#file94643line350>
> >
> >     maybe it should be i18n()'d?
> 
> Sven Brauch wrote:
>     No, in my opinion. It's an ellipsis operator for function arguments, like
>     uses in void function(...):
>     It's part of source code, and will probably not be translated anywhere.
> 
> Aleix Pol Gonzalez wrote:
>     Any user-visible string has to go through i18n.
>     
>     How do you know ellipsis is the same in any language?
> 
> Sven Brauch wrote:
>     It's a C++ syntax feature.
>     
>     int main(...) {
>      
>     }
>     
>     is valid C++ code. You wouldn't i18n the "int" or the "main" either if you displayed it, would you? :)
>     And the ellipsis is used in exactly this context here -- in order to not specify the parameters of a function explicitly.
> 
> Aleix Pol Gonzalez wrote:
>     It's valid C++ code but the uses widget is not only about C++.
>     
>     Anyhow, I guess it's fine if you want to leave it like that.

Okay, but other languages have an ellipsis operator too (python for example) -- plus, the brackets thing for the arguments is not generic either. So if you really wanted to make it programming-language agnostic, then you'd need to ask the language plugin for what a function (or, context) signature looks like. And that sounds over-engineered to me...

I mean, we can put it into an i18nc, but then we'd need a really good comment which explains where it's being used if we want to avoid getting some really weird results. And I so far failed to come up with a reasonably short and precise explanation :)


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107296/#review21856
-----------------------------------------------------------


On Nov. 14, 2012, 5:09 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107296/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2012, 5:09 p.m.)
> 
> 
> Review request for KDevelop, KDE Usability and Milian Wolff.
> 
> 
> Description
> -------
> 
> TL;DR: Look at the screenshots below. :)
> 
> Make the uses widget nicer.
> 
> Main changes include:
>  * Fix contexts not being clickable (they were clickable but didn't work)
>  * Remove the blue arrows; all widgets are expanded by default and can
>    be collapsed with a small link in the text instead. This operation is
>    not common enough to justify such a huge ugly button.
>    (The main problem with the button was that it looked ugly, tough)
>  * Contexts without actual uses are always sorted last.
>  * Add some nice icons to the list.
>  * Remove all the ugly frames.
>  * Make text displaying code use a fixed-width font.
>  * Make the tooltip use a fixed-width font too, make it smaller (just 2
>    lines of context instead of 3), and highlight the line with the use
>    by making it bold-face.
>  * Re-format and rename all the widget headers to be more readable
>    and look nicer.
> 
> I will add a few comments to the patch to explain what I was doing.
> 
> Oh and also, I had that impression for quite a while now, but right now I'm pretty sure the find uses feature is broken in some way. Just look at the screenshots: it found way more occurences in the first screenshot than in the second (which happened after a reparse of some projects). And this has nothing to do with my changes. :)
> 
> 
> Diffs
> -----
> 
>   language/duchain/navigation/useswidget.h ec0440e 
>   language/duchain/navigation/useswidget.cpp 8c01e7c 
>   shell/projectcontroller.cpp 6168066 
> 
> Diff: http://git.reviewboard.kde.org/r/107296/diff/
> 
> 
> Testing
> -------
> 
> Manual testing; no functional changes were done except for the context link fix.
> 
> 
> Screenshots
> -----------
> 
> Comparsion between the old and the new uses widget.
>   http://git.reviewboard.kde.org/r/107296/s/821/
> The new useswidget after the latest updates
>   http://git.reviewboard.kde.org/r/107296/s/822/
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121114/ee84a430/attachment.html>