Review Request: Segfault when opening project configuration for kdev-python project

[Sven Brauch]

> On Nov. 12, 2012, 12:44 a.m., Sven Brauch wrote:
> > Interesting, I never noticed that. But it indeed crashes.
> > What does it display when it works? Nothing, probably?
> > Maybe an error message should be displayed instead, then, saying that there's no configuration dialog for that project?
> > 
> > But not crashing is definitely much better than crashing, so I like this. :D
> 
> David Knapp wrote:
>     It displays the generic project config, I assume. This is the config window after the patch.
>     
>     http://imgur.com/lRp04
>     
>     The underlying problem could very well be in kdev-python. Something it's doing isn't implementing buildSystemManager() correctly or something, I really have no idea. I tried to hunt it down a little bit but I don't have all that much experience with this codebase.

Alright, that looks reasonable.

Nah, I'm the maintainer of kdev-python, it has no bugs. :D
Seriously tough, if the docstring says you don't have to implement it and returning 0 is okay, then doing that shouldn't crash :)
Also since Andreas said the fix is okay you can just push it (can you?).


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107291/#review21853
-----------------------------------------------------------


On Nov. 11, 2012, 6:12 a.m., David Knapp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107291/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2012, 6:12 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Fixes a segfault crash due to a null pointer exception when opening the project configuration for a kdev-python project. The docs for IProject::buildSystemManager() says "@return the build system manager for the project, if one exists; otherwise null". The code previously however relied on that call returning a non-null pointer.
> 
> 
> Diffs
> -----
> 
>   shell/projectcontroller.cpp 6168066 
> 
> Diff: http://git.reviewboard.kde.org/r/107291/diff/
> 
> 
> Testing
> -------
> 
> I can now open a config window for my python project
> 
> 
> Thanks,
> 
> David Knapp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121112/678b37b2/attachment.html>