Review Request: Make the uses widget nicer.

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107296/
-----------------------------------------------------------

(Updated Nov. 12, 2012, 11:04 a.m.)


Review request for KDevelop and Milian Wolff.


Changes
-------

I updated it again:
 * Removed the sizePrefix/sizeSuffix stuff since it was apparently unused for ages and I don't see a reason to have it everywhere
 * Hopefully make i18n a bit more obvious, and use setFont if the whole string is bold/italic
 * Make the button read "collapse" and "expand" instead of "toggle"
 * Make the slash in the path non-italic; italic slashes look very weird in most fonts, they intersect with the next letter and stuff

> I think the "1 use", "2 uses" etc. behind the actual code-entries could be removed.
I didn't do that yet, since I'm not really sure about it... you're right, it' just 1 or 2 pretty often which is sort of pointless, but it doesn't really hurt to leave it there, does it? I mean, it doesn't look ugly, and the space is unused otherwise anyways. And there's cases where there's a lot of uses, and you might want to know how many.
If you still think it's a good idea to remove it, I'll do so. :)


Description
-------

TL;DR: Look at the screenshots below. :)

Make the uses widget nicer.

Main changes include:
 * Fix contexts not being clickable (they were clickable but didn't work)
 * Remove the blue arrows; all widgets are expanded by default and can
   be collapsed with a small link in the text instead. This operation is
   not common enough to justify such a huge ugly button.
   (The main problem with the button was that it looked ugly, tough)
 * Contexts without actual uses are always sorted last.
 * Add some nice icons to the list.
 * Remove all the ugly frames.
 * Make text displaying code use a fixed-width font.
 * Make the tooltip use a fixed-width font too, make it smaller (just 2
   lines of context instead of 3), and highlight the line with the use
   by making it bold-face.
 * Re-format and rename all the widget headers to be more readable
   and look nicer.

I will add a few comments to the patch to explain what I was doing.

Oh and also, I had that impression for quite a while now, but right now I'm pretty sure the find uses feature is broken in some way. Just look at the screenshots: it found way more occurences in the first screenshot than in the second (which happened after a reparse of some projects). And this has nothing to do with my changes. :)


Diffs (updated)
-----

  language/duchain/navigation/useswidget.h ec0440e 
  language/duchain/navigation/useswidget.cpp 8c01e7c 
  shell/projectcontroller.cpp 6168066 

Diff: http://git.reviewboard.kde.org/r/107296/diff/


Testing
-------

Manual testing; no functional changes were done except for the context link fix.


Screenshots
-----------

Comparsion between the old and the new uses widget.
  http://git.reviewboard.kde.org/r/107296/s/821/


Thanks,

Sven Brauch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121112/5e97b407/attachment.html>