Review Request: Make the uses widget nicer.

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107296/#review21852
-----------------------------------------------------------



language/duchain/navigation/useswidget.h
<http://git.reviewboard.kde.org/r/107296/#comment16852>

    This is required for the icon



language/duchain/navigation/useswidget.h
<http://git.reviewboard.kde.org/r/107296/#comment16853>

    for changing the margins in the list



language/duchain/navigation/useswidget.h
<http://git.reviewboard.kde.org/r/107296/#comment16854>

    this is later used to sort the entries



language/duchain/navigation/useswidget.cpp
<http://git.reviewboard.kde.org/r/107296/#comment16855>

    This whole thing (clicking the context links) seemed to rely on abstractdeclarationnavigationwidget. This is very weird since all this code has nothing to with abstractdeclarationnavigationwidget. The uses widget does not inherit from that class, and thus no signal was connected to the click event. Also, a declaration navigation feature is totally unsuitable here since it is supposed to jump to a context.



language/duchain/navigation/useswidget.cpp
<http://git.reviewboard.kde.org/r/107296/#comment16856>

    Do I need to hold the foreground lock here?



language/duchain/navigation/useswidget.cpp
<http://git.reviewboard.kde.org/r/107296/#comment16857>

    Not required any more since it's handled directly in the link clicked method


- Sven Brauch


On Nov. 12, 2012, 12:11 a.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107296/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2012, 12:11 a.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Description
> -------
> 
> TL;DR: Look at the screenshots below. :)
> 
> Make the uses widget nicer.
> 
> Main changes include:
>  * Fix contexts not being clickable (they were clickable but didn't work)
>  * Remove the blue arrows; all widgets are expanded by default and can
>    be collapsed with a small link in the text instead. This operation is
>    not common enough to justify such a huge ugly button.
>    (The main problem with the button was that it looked ugly, tough)
>  * Contexts without actual uses are always sorted last.
>  * Add some nice icons to the list.
>  * Remove all the ugly frames.
>  * Make text displaying code use a fixed-width font.
>  * Make the tooltip use a fixed-width font too, make it smaller (just 2
>    lines of context instead of 3), and highlight the line with the use
>    by making it bold-face.
>  * Re-format and rename all the widget headers to be more readable
>    and look nicer.
> 
> I will add a few comments to the patch to explain what I was doing.
> 
> Oh and also, I had that impression for quite a while now, but right now I'm pretty sure the find uses feature is broken in some way. Just look at the screenshots: it found way more occurences in the first screenshot than in the second (which happened after a reparse of some projects). And this has nothing to do with my changes. :)
> 
> 
> Diffs
> -----
> 
>   language/duchain/navigation/useswidget.h ec0440e 
>   language/duchain/navigation/useswidget.cpp 8c01e7c 
> 
> Diff: http://git.reviewboard.kde.org/r/107296/diff/
> 
> 
> Testing
> -------
> 
> Manual testing; no functional changes were done except for the context link fix.
> 
> 
> Screenshots
> -----------
> 
> Comparsion between the old and the new uses widget.
>   http://git.reviewboard.kde.org/r/107296/s/821/
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121112/50013b76/attachment.html>